Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ATV] Cannot exit playing session with native player #925

Closed
ShadowJonathan opened this issue Nov 18, 2023 · 2 comments · Fixed by #947
Closed

[ATV] Cannot exit playing session with native player #925

ShadowJonathan opened this issue Nov 18, 2023 · 2 comments · Fixed by #947
Labels
bug Something isn't working

Comments

@ShadowJonathan
Copy link

Describe the bug

  1. Login/setup Swiftfin \w Jellyfin server
  2. Go to settings, toggle "player" to "native"
  3. Go to any media, play
  4. Press "return", see that it doesn't work, except the main-menu long-press return

Application version

Latest main, eb17300

Where did you install the app from?

None

Device information

Apple TV HD

OS version

tvOS 17.1

Jellyfin server version

10.8.12

@ShadowJonathan ShadowJonathan added the bug Something isn't working label Nov 18, 2023
@elliots
Copy link
Contributor

elliots commented Dec 28, 2023

Adding this to nativeplayer fixes it, but it isn't perfect as when you hit back while the info is displaying, it should just hide it instead of closing the video.

override func pressesBegan(_ presses: Set<UIPress>, with event: UIPressesEvent?) {
        super.pressesBegan(presses, with: event)
    
        for press in presses {
            if press.type == .menu {
                self.stop()
                self.dismiss(animated: true, completion: nil)
            }
        }
    }

Anyone know how to fix that?

@nokeeo
Copy link
Contributor

nokeeo commented Jan 9, 2024

We can implement AVPlayerViewControllerDelegate to determine when to dismiss. #947 fixes this. PTAL when you all have a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants