[tvOS][QOL] Supports back button click when in the native player. #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nokeeo
changed the title
|
ping @LePips for review or please assign to whomever is appropriate. |
LePips
requested changes
Jan 13, 2024
LePips
requested changes
Jan 13, 2024
There was a problem hiding this comment.
Just some cleanup, good to have the refactor comment about subclassing from AVPlayerViewController. Yeah it says subclassing isn't supported but we can generally get away/lazy with it, but we should wrap that into a parent view/VC that interacts with the underlying AVPlayerViewController.
LePips
requested changes
Jan 15, 2024
|
Done. PTAL. |
LePips
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conforms
UINativeVideoPlayerViewControllertoAVPlayerViewControllerDelegateand implementsplayerViewControllerShouldDismiss. This method is called by AV player view controller when the player should be dismissed. This function is only called when the playback overlay is not displayed otherwise a back button press will dismiss the overlay.Fixes #925