Minor Fix for Search View and Poster Button Text #964
Conversation
Fixes the Search View by adding padding to the results. Before the search "keyboard' would overlap the results but now the results will appear below the keyboard. I also added padding to the poster buttons text/title. When you would hover an item it would slightly cover the text/title. Now it should always be completely visible.
After looking at the code once more and looking up what .ignoresSafeArea() does. I removed it from the code and it does what I was trying to do from the begginning. So I removed my code changes there and just removed the ignoresSafeArea call. Maybe it was placed there by mistake.
|
After looking at the code once more and looking up what .ignoresSafeArea() does. I removed it from the code and it does what I was trying to do from the begginning. So I removed my code changes there and just removed the ignoresSafeArea call. Maybe it was placed there by mistake. |
Add back in .ignoreSafeArea upon request but only for the bottom and sides. Should still fix the overlap issue with the keyboard.
|
Looks like the build failed. The only thing I see is the line "error: value of type '_UnsafeBitset' has no member 'isEmpty'" during the build process. |
|
Also it looks like the PR is stating that 1 changes is still requested but I think I "resolved" both changes. If there is something else your are looking for let me know. Otherwise I think its good to go. Thanks. |
|
I realized on the Search View I placed the ignoreSafeArea on the wrong thing. It was on the VStack when originally it was on the View. |
|
Will do. I'll give it a shot today at some point. |
|
I have merged from upstream master. There were just two commits missing. Should be good to go? |
Fixes the Search View by adding padding/margin to the results. Before the search "keyboard' would overlap the results but now the results will appear below the keyboard. I am guessing the "keyboard" is not really a item in the view/stack from what I could tell and is a built in element that will overlap items if not accounted for. If there is a better way to handle this feel free to correct it but this was a fairly simple fix. It uses a percentage (65%) of the screen geometry to place the results, so in theory it should work on any screen but I tested in the simulator with 4k and 1080p and it seems to work alright. Maybe on more vertical spaced screens it might be off but I am thinking the keyboard will always take up approximately the same amount of space. Maybe the percentage could be based on screen size ratios?
I also added padding to the poster buttons text/title. When you would hover an item it would slightly cover the text/title. Now it should always be completely visible.