Fix setting the docker registry organisation #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… docker regsitry organization
…gistry org in build pipelines
|
Is the Makefile in the main charts (not the preview charts) used anymore? because I don't see it used anywhere in the Jenkinsfile steps |
|
@garethjevans Is there a need for this after this #49? Do I close? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://github.com/jenkins-x/jx/blob/master/pkg/jx/cmd/import.go it's assumed that there's a REPLACE_ME_DOCKER_REGISTRY_ORG replacement holder in build packs, but actually there's none.
This PR adds the replacement holder, and it also uses the DOCKER_REGISTRY_ORG env variable instead of the ORG env to hold the docker registry organisation in the build pipelines given this PR is merged first jenkins-x-buildpacks/jenkins-x-classic#5.