-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Terraform Build Pack #45
base: master
Are you sure you want to change the base?
Adding Terraform Build Pack #45
Conversation
- docker: {} | ||
tagPolicy: | ||
envTemplate: | ||
template: '{{.DOCKER_REGISTRY}}/REPLACE_ME_ORG/REPLACE_ME_APP_NAME:{{.DIGEST_HEX}}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{.DIGEST_HEX}} is no longer supported in skaffold
packs/terraform/skaffold.yaml
Outdated
chartPath: charts/REPLACE_ME_APP_NAME | ||
setValueTemplates: | ||
image.repository: '{{.DOCKER_REGISTRY}}/REPLACE_ME_ORG/REPLACE_ME_APP_NAME' | ||
image.tag: '{{.DIGEST_HEX}}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
@sharepointoscar I may have mis-understood here, but my assumption was that a terraform buildpack wouldn't create an "app" that can be deployed to k8s? It would create something that could be validated / executed against a cloud provider (or something that is terraform managed). |
@garethjevans That is correct, was an oversight on my part and thanks for the quick review. I think what I want my |
Do we need to create an image with Dockerfile? Shouldn't the pipeline reference an image with Terraform and execute commands using checked out code (e.g., |
The |
What is the plan with the credentials? I assume they would be provided as a k8s secret or from Vault and injected through the pipeline. |
@sharepointoscar Hi, how do you perform testing using Terraform? Thank you. |
hello, can I know the status of this issue? I'm planning to do a terraform build pack as well, hope can contribute :) |
Wanted to have someone take a look at the draft Terraform Build Pack. I have tested it locally, it runs as expected.