Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dependency upgrades and cleanup #550

Merged
merged 3 commits into from
Jan 14, 2025
Merged

fix: dependency upgrades and cleanup #550

merged 3 commits into from
Jan 14, 2025

Conversation

msvticket
Copy link
Contributor

@msvticket msvticket commented Jan 9, 2025

Removing dead code

Removing code related to the deprecated jenkins-x.yaml project configuration file

A lot of the removed code broke with upgrade of tekton pipelines

Support new goreleaser

related to jenkins-x/jx#8670

removing dead code
removing remnants of code related to jenkins-x.yaml
support goreleaser

related to jenkins-x/jx#8670
@msvticket
Copy link
Contributor Author

/cc tomhobson JordanGoasdoue Skisocks mentlak0

@msvticket
Copy link
Contributor Author

/test pr
/test lint

@msvticket
Copy link
Contributor Author

/test pr

stop using draft library unnecessarily
add version command

related to jenkins-x/jx#8670
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@msvticket msvticket changed the title fix: upgrade go 1.23 and dependencies fix: dependency upgrades and clenup Jan 13, 2025
@msvticket msvticket changed the title fix: dependency upgrades and clenup fix: dependency upgrades and cleanup Jan 13, 2025
@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Skisocks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@msvticket
Copy link
Contributor Author

/retest

@jenkins-x-bot jenkins-x-bot merged commit 9e0c1a9 into main Jan 14, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants