Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade kubectl to 1.22.5 #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yelhouti
Copy link

No description provided.

@jenkins-x-bot
Copy link
Contributor

Hi @yelhouti. Thanks for your PR.

I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@yelhouti
Copy link
Author

/assign @jstrachan
If you still have access XD

@ankitm123
Copy link
Member

/ok-to-test

@ankitm123
Copy link
Member

/lgtm

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ankitm123
To complete the pull request process, please assign jstrachan
You can assign the PR to them by writing /assign @jstrachan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot
Copy link
Contributor

@yelhouti: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pr 568ba47 link /test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@ankitm123
Copy link
Member

/cc @rawlingsj

@ankitm123
Copy link
Member

/hold
can we keep this at 1.21, as that would gurantee it works with 1.20 and 1.22? I am interested to see why the job failed ...

@yelhouti
Copy link
Author

yelhouti commented Feb 3, 2022

I don't have the error message anymore, but it would error on many kubectl requests because of some check that was probably added in the end and not handled correctly by older API versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants