Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't require cluster for cli upgrade #8738

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

msvticket
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 31.60%. Comparing base (43f1b36) to head (514d22a).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cmd/upgrade/upgrade_cli.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8738      +/-   ##
==========================================
- Coverage   31.62%   31.60%   -0.03%     
==========================================
  Files          11       11              
  Lines        1369     1370       +1     
==========================================
  Hits          433      433              
- Misses        891      893       +2     
+ Partials       45       44       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mårten Svantesson <Marten.Svantesson@ticket.se>
@msvticket msvticket force-pushed the dont-require-cluster branch from 8713e48 to 514d22a Compare January 15, 2025 12:08
@msvticket
Copy link
Member Author

/cc tomhobson JordanGoasdoue Skisocks mentlak0

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Skisocks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 1f84e7c into main Jan 15, 2025
8 of 11 checks passed
@jenkins-x-bot jenkins-x-bot deleted the dont-require-cluster branch January 15, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants