Merge remote-tracking branch 'origin/main' into remove-line-range

jenkinsci · Feb 20, 2024 · ee276a8 · ee276a8
2 parents c55d0d4 + 7248084
commit ee276a8
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/src/main/java/edu/hm/hafner/analysis/FingerprintGenerator.java b/src/main/java/edu/hm/hafner/analysis/FingerprintGenerator.java
@@ -53,7 +53,12 @@ public void run(final FullTextFingerprint algorithm, final Report report, final
     }
 
     private boolean hasAllowedExtension(final String fileName) {
-        return !NON_SOURCE_CODE_EXTENSIONS.contains(StringUtils.lowerCase(FilenameUtils.getExtension(fileName)));
+        try {
+            return !NON_SOURCE_CODE_EXTENSIONS.contains(StringUtils.lowerCase(FilenameUtils.getExtension(fileName)));
+        }
+        catch (IllegalArgumentException exception) {
+            return false; // if the file name is invalid, we assume that it is not a source code file
+        }
     }
 
     private int computeFingerprint(final Issue issue, final FullTextFingerprint algorithm, final Charset charset,

diff --git a/src/test/java/edu/hm/hafner/analysis/FingerprintGeneratorTest.java b/src/test/java/edu/hm/hafner/analysis/FingerprintGeneratorTest.java
@@ -155,6 +155,20 @@ void shouldUseFallbackFingerprintOnNonSourceFiles(final String fileName) {
         assertThatIssueHasDefaultFingerprint(report);
     }
 
+    @ParameterizedTest(name = "[{index}] Skip illegal source code files on Windows {0}")
+    @ValueSource(strings = {"prefix::suffix.txt", ":"})
+    void shouldUseFallbackFingerprintOnIllegalFilenamesOnWindows(final String fileName) {
+        assumeThatTestIsRunningOnWindows();
+
+        var report = createReportWithOneIssueFor(fileName);
+
+        FingerprintGenerator generator = new FingerprintGenerator();
+        generator.run(createFullTextFingerprint("fingerprint-two.txt"),
+                report, CHARSET_AFFECTED_FILE);
+
+        assertThatIssueHasDefaultFingerprint(report);
+    }
+
     private Report createReportWithOneIssueFor(final String fileName) {
         Report report;
         try (IssueBuilder issueBuilder = new IssueBuilder()) {