Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore files that cause an exception while determining the prefix #1023

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Feb 20, 2024

Processing file names with colons will produce a IAE omn Windows: those files can be ignored during fingerprinting.

Also:   org.jenkinsci.plugins.workflow.actions.ErrorAction$ErrorId: 23d30129-9137-4261-a261-7f362ba83618 java.lang.IllegalArgumentException: NTFS ADS separator (':') in file name is forbidden.
	at org.apache.commons.io.FilenameUtils.indexOfExtension(FilenameUtils.java:955)
	at org.apache.commons.io.FilenameUtils.getExtension(FilenameUtils.java:614)
	at edu.hm.hafner.analysis.FingerprintGenerator.hasAllowedExtension(FingerprintGenerator.java:56)
	at edu.hm.hafner.analysis.FingerprintGenerator.run(FingerprintGenerator.java:43)
	at io.jenkins.plugins.analysis.core.steps.IssuesScanner$ReportPostProcessor.createFingerprints(IssuesScanner.java:363)
	at io.jenkins.plugins.analysis.core.steps.IssuesScanner$ReportPostProcessor.invoke(IssuesScanner.java:290)
	at io.jenkins.plugins.analysis.core.steps.IssuesScanner$ReportPostProcessor.invoke(IssuesScanner.java:247)
	at hudson.FilePath.act(FilePath.java:1236)
	at hudson.FilePath.act(FilePath.java:1219)
	at io.jenkins.plugins.analysis.core.steps.IssuesScanner.postProcessReport(IssuesScanner.java:139)
	at io.jenkins.plugins.analysis.core.steps.IssuesScanner.scan(IssuesScanner.java:115)
	at io.jenkins.plugins.analysis.core.steps.IssuesRecorder.scanWithTool(IssuesRecorder.java:687)
	at io.jenkins.plugins.analysis.core.steps.IssuesRecorder.record(IssuesRecorder.java:649)
	at io.jenkins.plugins.analysis.core.steps.IssuesRecorder.perform(IssuesRecorder.java:617)
	at io.jenkins.plugins.analysis.core.steps.RecordIssuesStep$Execution.run(RecordIssuesStep.java:611)
	at io.jenkins.plugins.analysis.core.steps.RecordIssuesStep$Execution.run(RecordIssuesStep.java:568)
	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:840)

@uhafner uhafner added the bug Bugs or performance problems label Feb 20, 2024
Copy link

☀️ Quality Monitor

  • 🚦 Tests: 1283 tests passed, 2 skipped
  • 👣 Code Coverage: 90% coverage achieved
  • ⚠️ Style: No warnings found
  • 🐛 Bugs: 6 warnings found (0 error, 0 high, 0 normal, 6 low)

More details are available in the GitHub Checks Result.

Copy link

☀️ Quality Monitor

  • 🚦 Tests: 1283 tests passed, 2 skipped
  • 👣 Code Coverage: 90% coverage achieved
  • ⚠️ Style: No warnings found
  • 🐛 Bugs: 6 warnings found (0 error, 0 high, 0 normal, 6 low)

More details are available in the GitHub Checks Result.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3460211) 89.68% compared to head (0c2b59a) 89.66%.
Report is 5 commits behind head on main.

Files Patch % Lines
...a/edu/hm/hafner/analysis/FingerprintGenerator.java 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1023      +/-   ##
============================================
- Coverage     89.68%   89.66%   -0.03%     
  Complexity     2284     2284              
============================================
  Files           354      354              
  Lines          6692     6694       +2     
  Branches        698      698              
============================================
  Hits           6002     6002              
- Misses          488      490       +2     
  Partials        202      202              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uhafner uhafner merged commit 7248084 into main Feb 20, 2024
27 of 29 checks passed
@uhafner uhafner deleted the IAE-windows-invalid-filenames branch February 20, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant