-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parsing for mixture of Kotlin and CMake output #991
Fix parsing for mixture of Kotlin and CMake output #991
Conversation
aa4ac70
to
2eb9975
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #991 +/- ##
============================================
- Coverage 93.09% 93.08% -0.01%
- Complexity 2382 2386 +4
============================================
Files 347 347
Lines 6603 6612 +9
Branches 687 689 +2
============================================
+ Hits 6147 6155 +8
- Misses 256 257 +1
Partials 200 200 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your pull request! Just a small simplification would be helpful.
2259f63
to
54accae
Compare
To make sure this works for building on all platforms, I also added a Windows path to the log and did some adjustments for it to work as well. |
54accae
to
5619556
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good now! Only the tests could use better assertions for the file names.
d2190c7
to
5aab948
Compare
For projects with a mixture of Kotlin and CMake compiles the output of both can be mixed depending on the order of the tasks. The working path defined by the CMake output should not be used for warnings which already print out absolute paths e.g. Kotlin warnings. It should only be used if the path is a relative path.
Testing done
Submitter checklist