Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate cd. #115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Automate cd. #115

wants to merge 1 commit into from

Conversation

XiongKezhi
Copy link
Contributor

Automated cd following https://www.jenkins.io/doc/developer/publishing/releasing-cd/.

Try to remain the semVer and use the generated number as patch version, so the expected format should be 1.7-123.vabcdef456789.

One problem: in this cd model, should we release a new version once we bump a new version of dependency? How can we avoid it if not?

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@XiongKezhi XiongKezhi requested a review from a team June 10, 2021 09:49
@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.38%. Comparing base (9a99cc3) to head (b652d16).
Report is 121 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #115      +/-   ##
============================================
- Coverage     85.52%   85.38%   -0.14%     
  Complexity      152      152              
============================================
  Files            17       17              
  Lines           746      746              
  Branches         57       57              
============================================
- Hits            638      637       -1     
- Misses           88       89       +1     
  Partials         20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiongKezhi XiongKezhi requested a review from timja June 17, 2021 02:38
<packaging>hpi</packaging>

<name>Checks API plugin</name>
<description>Defines an API for Jenkins to publish checks to SCM platforms.</description>

<properties>
<java.level>8</java.level>
<revision>1.7.1</revision>
<changelist>-SNAPSHOT</changelist>
<revision>1.7</revision>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you trying to keep some form of versioning here rather than just commit count?

the format you're is recommended for 'wrapped' components, i.e. api libraries.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I'm trying to use the generated number as the "patch" version in semantic versioning. But that introduces a problem: what if I want to release the next minor version? If using this automated cd, it seems I have to file a PR to update the version number and get it merged.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tekton client plugin does it with semantic commits I think: https://github.com/jenkinsci/tekton-client-plugin/blob/master/.github/workflows/cd.yaml#L26

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you search 'Manually controlled prefix' on this page https://www.jenkins.io/doc/developer/publishing/releasing-cd/

you will get something similar with at least a low version number

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,3 +1,2 @@
_extends: .github
version-template: $MAJOR.$MINOR.$PATCH
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version-template: $MAJOR.$MINOR.$PATCH

@jglick
Copy link
Member

jglick commented May 13, 2022

Also

<parent>
<groupId>org.jvnet.hudson.plugins</groupId>
<artifactId>analysis-pom</artifactId>
<version>5.24.0</version>
<relativePath />
</parent>
is a red flag. Switch to the normal parent POM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants