-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate cd. #115
base: master
Are you sure you want to change the base?
Automate cd. #115
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #115 +/- ##
============================================
- Coverage 85.52% 85.38% -0.14%
Complexity 152 152
============================================
Files 17 17
Lines 746 746
Branches 57 57
============================================
- Hits 638 637 -1
- Misses 88 89 +1
Partials 20 20 ☔ View full report in Codecov by Sentry. |
<packaging>hpi</packaging> | ||
|
||
<name>Checks API plugin</name> | ||
<description>Defines an API for Jenkins to publish checks to SCM platforms.</description> | ||
|
||
<properties> | ||
<java.level>8</java.level> | ||
<revision>1.7.1</revision> | ||
<changelist>-SNAPSHOT</changelist> | ||
<revision>1.7</revision> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you trying to keep some form of versioning here rather than just commit count?
the format you're is recommended for 'wrapped' components, i.e. api libraries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I'm trying to use the generated number as the "patch" version in semantic versioning. But that introduces a problem: what if I want to release the next minor version? If using this automated cd, it seems I have to file a PR to update the version number and get it merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tekton client plugin does it with semantic commits I think: https://github.com/jenkinsci/tekton-client-plugin/blob/master/.github/workflows/cd.yaml#L26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you search 'Manually controlled prefix' on this page https://www.jenkins.io/doc/developer/publishing/releasing-cd/
you will get something similar with at least a low version number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As noted in https://www.jenkins.io/doc/developer/publishing/releasing-cd/#update-maven-pom-and-config this style is not recommended.
@@ -1,3 +1,2 @@ | |||
_extends: .github | |||
version-template: $MAJOR.$MINOR.$PATCH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version-template: $MAJOR.$MINOR.$PATCH |
Also Lines 5 to 10 in a278bc3
|
Automated cd following https://www.jenkins.io/doc/developer/publishing/releasing-cd/.
Try to remain the semVer and use the generated number as patch version, so the expected format should be 1.7-123.vabcdef456789.
One problem: in this cd model, should we release a new version once we bump a new version of dependency? How can we avoid it if not?