Simplify status checks output for "error" and "unstable" steps #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In status checks, if the run failed because of an "error" pipeline step, then use the first line of the error message in the title of ChecksOutput, instead of "error in 'error' step". However, keep the original behaviour if the error message does not match the "message" argument of the step, if the step has other arguments, or if the first line of the message is empty. Update the test so that it keeps passing,
In status checks, omit the name and arguments of the "error" or "unstable" step from the output if the error or warning message matches the "message" argument of the step and there are no other arguments. Update the tests so that they keep passing.
|
This needs a new test for the case where the arguments of the step are still displayed. Although one test already runs |
KalleOlaviNiemitalo
changed the title
|
I probably won't continue this before 2021-09-18. |
justinmchase
reviewed
Sep 8, 2021
| if (message != null) { | ||
| final String firstLine = message.split("\r?\n", 2)[0]; | ||
| if (!firstLine.isEmpty()) { | ||
| return firstLine; |
There was a problem hiding this comment.
Perhaps add a maximum length on here too in case the first line is something crazy long?
return firstLine.length > 256 ? firstLine.substr(0, 255) + "…" : firstLine;
|
Hows it going here? |
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to fix #124 but not yet ready.