refactor: [#385] simplify logic for isEligibleToBreed

jeremyckahn · Jan 28, 2023 · 560385c · 560385c
1 parent 789e3c3
commit 560385c
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/components/CowCard/Subheader/Subheader.js b/src/components/CowCard/Subheader/Subheader.js
@@ -57,11 +57,10 @@ const Subheader = ({
 
   const mateId = cowBreedingPen.cowId1 ?? cowBreedingPen.cowId2
   const mate = getCowMapById(cowInventory)[mateId]
+  const isEligibleToBreed = cow.gender !== mate?.gender
 
-  const isEligibleToBreed =
-    (!mate || cow.gender !== mate.gender) && !isThisCowOfferedForTrade
-
-  const canBeMovedToBreedingPen = isRoomInBreedingPen && isEligibleToBreed
+  const canBeMovedToBreedingPen =
+    isRoomInBreedingPen && isEligibleToBreed && !isThisCowOfferedForTrade
 
   const disableBreedingControlTooltip =
     !canBeMovedToBreedingPen && !isInBreedingPen