feat: show age for cows offered for trade (#443) #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to a Personal Account owned by @jeremyckahn on Vercel. @jeremyckahn first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you for this PR @MarquisDeMizzle! I don't have much free time in the next few days, but I will prioritize reviewing this once I'm available to do so. 🙂 |
jeremyckahn
approved these changes
Feb 11, 2024
There was a problem hiding this comment.
Beautiful work, @MarquisDeMizzle! LGTM. I'll get this merged and released.
Are the tests too much?
I don't think so. Thanks for taking the time to add test coverage! 🙂
jeremyckahn
added a commit
that referenced
this pull request
Apr 18, 2024
jeremyckahn
added a commit
that referenced
this pull request
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Closes #443 by displaying age of cows offered for trade
How this change can be validated
New tests added, one of which fails without this Subheader.js change
Questions or concerns about this change
Are the tests too much?
Additional information