Add custom dispatcher to Arraybuffer & Arraybuffer_prototype

JerryScript-DCO-1.0-Signed-off-by: Orkenyi Virag orkvi@inf.u-szeged.hu

jerry-core/ecma/builtin-objects/ecma-builtin-arraybuffer-prototype.c

@@ -31,6 +31,21 @@
 #define ECMA_BUILTINS_INTERNAL
 #include "ecma-builtins-internal.h"
 
+/**
+ * This object has a custom dispatch function.
+ */
+#define BUILTIN_CUSTOM_DISPATCH
+
+/**
+ * List of built-in routine identifiers.
+ */
+enum
+{
+  ECMA_BUILTIN_ARRAYBUFFER_PROTOTYPE_ROUTINE_START = 0,
+  ECMA_BUILTIN_ARRAYBUFFER_PROTOTYPE_BYTELENGTH_GETTER,
+  ECMA_BUILTIN_ARRAYBUFFER_PROTOTYPE_OBJECT_SLICE,
+};
+
 #define BUILTIN_INC_HEADER_NAME "ecma-builtin-arraybuffer-prototype.inc.h"
 #define BUILTIN_UNDERSCORED_ID arraybuffer_prototype
 #include "ecma-builtin-internal-routines-template.inc.h"
@@ -55,25 +70,18 @@
  *         Returned value must be freed with ecma_free_value.
  */
 static ecma_value_t
-ecma_builtin_arraybuffer_prototype_bytelength_getter (ecma_value_t this_arg) /**< this argument */
+ecma_builtin_arraybuffer_prototype_bytelength_getter (ecma_value_t this_arg,
+                                                      ecma_object_t *object_p)
 {
-  if (ecma_is_value_object (this_arg))
+  JERRY_UNUSED (this_arg);
+  if (ecma_arraybuffer_is_detached (object_p))
   {
-    ecma_object_t *object_p = ecma_get_object_from_value (this_arg);
-
-    if (ecma_object_class_is (object_p, ECMA_OBJECT_CLASS_ARRAY_BUFFER))
-    {
-      if (ecma_arraybuffer_is_detached (object_p))
-      {
-        return ecma_raise_type_error (ECMA_ERR_MSG (ecma_error_arraybuffer_is_detached));
-      }
-      uint32_t len = ecma_arraybuffer_get_length (object_p);
-
-      return ecma_make_uint32_value (len);
-    }
+    return ecma_raise_type_error (ECMA_ERR_MSG (ecma_error_arraybuffer_is_detached));
   }
+  uint32_t len = ecma_arraybuffer_get_length (object_p);
+
+  return ecma_make_uint32_value (len);
 
-  return ecma_raise_type_error (ECMA_ERR_MSG ("Argument 'this' is not a ArrayBuffer object"));
 } /* ecma_builtin_arraybuffer_prototype_bytelength_getter */
 
 /**
@@ -89,6 +97,22 @@ static ecma_value_t
 ecma_builtin_arraybuffer_prototype_object_slice (ecma_value_t this_arg, /**< this argument */
                                                  const ecma_value_t *argument_list_p, /**< arguments list */
                                                  uint32_t arguments_number) /**< number of arguments */
+{
+  return ecma_builtin_arraybuffer_slice (this_arg, argument_list_p, arguments_number);
+} /* ecma_builtin_arraybuffer_prototype_object_slice */
+
+/**
+ * Dispatcher of the built-in's routines
+ *
+ * @return ecma value
+ *         Returned value must be freed with ecma_free_value.
+ */
+ecma_value_t
+ecma_builtin_arraybuffer_prototype_dispatch_routine (uint8_t builtin_routine_id, /**< built-in routine identifier */
+                                                     ecma_value_t this_arg, /**< 'this' argument value */
+                                                     const ecma_value_t arguments_list_p[], /**< list of arguments
+                                                                                            *   passed to routine */
+                                                     uint32_t arguments_number) /**< length of arguments' list */
 {
   if (!ecma_is_value_object (this_arg))
   {
@@ -103,8 +127,22 @@ ecma_builtin_arraybuffer_prototype_object_slice (ecma_value_t this_arg, /**< thi
     return ecma_raise_type_error (ECMA_ERR_MSG ("Argument 'this' is not an ArrayBuffer object"));
   }
 
-  return ecma_builtin_arraybuffer_slice (this_arg, argument_list_p, arguments_number);
-} /* ecma_builtin_arraybuffer_prototype_object_slice */
+  switch (builtin_routine_id)
+  {
+    case ECMA_BUILTIN_ARRAYBUFFER_PROTOTYPE_BYTELENGTH_GETTER:
+    {
+      return ecma_builtin_arraybuffer_prototype_bytelength_getter (this_arg, object_p);
+    }
+    case ECMA_BUILTIN_ARRAYBUFFER_PROTOTYPE_OBJECT_SLICE:
+    {
+      return ecma_builtin_arraybuffer_prototype_object_slice (this_arg, arguments_list_p, arguments_number);
+    }
+    default:
+    {
+      JERRY_UNREACHABLE ();
+    }
+  }
+} /* ecma_builtin_arraybuffer_prototype_dispatch_routine */
 
 /**
  * @}

jerry-core/ecma/builtin-objects/ecma-builtin-arraybuffer-prototype.inc.h

@@ -30,7 +30,7 @@ OBJECT_VALUE (LIT_MAGIC_STRING_CONSTRUCTOR,
 
 /* Readonly accessor properties */
 ACCESSOR_READ_ONLY (LIT_MAGIC_STRING_BYTE_LENGTH_UL,
-                    ecma_builtin_arraybuffer_prototype_bytelength_getter,
+                    ECMA_BUILTIN_ARRAYBUFFER_PROTOTYPE_BYTELENGTH_GETTER,
                     ECMA_PROPERTY_FLAG_CONFIGURABLE)
 
 /* ECMA-262 v6, 24.1.4.4 */
@@ -40,7 +40,7 @@ STRING_VALUE (LIT_GLOBAL_SYMBOL_TO_STRING_TAG,
 
 /* Routine properties:
  *  (property name, C routine name, arguments number or NON_FIXED, value of the routine's length property) */
-ROUTINE (LIT_MAGIC_STRING_SLICE, ecma_builtin_arraybuffer_prototype_object_slice, NON_FIXED, 2)
+ROUTINE (LIT_MAGIC_STRING_SLICE, ECMA_BUILTIN_ARRAYBUFFER_PROTOTYPE_OBJECT_SLICE, NON_FIXED, 2)
 
 #endif /* JERRY_BUILTIN_TYPEDARRAY */
 

jerry-core/ecma/builtin-objects/ecma-builtin-arraybuffer.c

@@ -28,6 +28,21 @@
 #define ECMA_BUILTINS_INTERNAL
 #include "ecma-builtins-internal.h"
 
+/**
+ * This object has a custom dispatch function.
+ */
+#define BUILTIN_CUSTOM_DISPATCH
+
+/**
+ * List of built-in routine identifiers.
+ */
+enum
+{
+  ECMA_BUILTIN_ARRAYBUFFER_ROUTINE_START = 0,
+  ECMA_BUILTIN_ARRAYBUFFER_OBJECT_IS_VIEW,
+  ECMA_BUILTIN_ARRAYBUFFER_SPECIES_GET,
+};
+
 #define BUILTIN_INC_HEADER_NAME "ecma-builtin-arraybuffer.inc.h"
 #define BUILTIN_UNDERSCORED_ID arraybuffer
 #include "ecma-builtin-internal-routines-template.inc.h"
@@ -93,16 +108,37 @@ ecma_builtin_arraybuffer_dispatch_construct (const ecma_value_t *arguments_list_
 } /* ecma_builtin_arraybuffer_dispatch_construct */
 
 /**
- * 24.1.3.3 get ArrayBuffer [ @@species ] accessor
+ * Dispatcher of the built-in's routines
  *
- * @return ecma_value
- *         returned value must be freed with ecma_free_value
+ * @return ecma value
+ *         Returned value must be freed with ecma_free_value.
  */
 ecma_value_t
-ecma_builtin_arraybuffer_species_get (ecma_value_t this_value) /**< This Value */
+ecma_builtin_arraybuffer_dispatch_routine (uint8_t builtin_routine_id, /**< built-in wide routine identifier */
+                                           ecma_value_t this_arg, /**< 'this' argument value */
+                                           const ecma_value_t arguments_list_p[], /**< list of arguments
+                                                                                  *   passed to routine */
+                                           uint32_t arguments_number) /**< length of arguments' list */
 {
-  return ecma_copy_value (this_value);
-} /* ecma_builtin_arraybuffer_species_get */
+  JERRY_UNUSED (arguments_number);
+
+  switch (builtin_routine_id)
+  {
+    case ECMA_BUILTIN_ARRAYBUFFER_OBJECT_IS_VIEW:
+    {
+      ecma_value_t argument = arguments_number > 0 ? arguments_list_p[0] : ECMA_VALUE_UNDEFINED;
+      return ecma_builtin_arraybuffer_object_is_view (this_arg, argument);
+    }
+    case ECMA_BUILTIN_ARRAYBUFFER_SPECIES_GET:
+    {
+      return ecma_copy_value (this_arg);
+    }
+    default:
+    {
+      JERRY_UNREACHABLE ();
+    }
+  }
+} /* ecma_builtin_arraybuffer_dispatch_routine */
 
 /**
  * @}

jerry-core/ecma/builtin-objects/ecma-builtin-arraybuffer.inc.h

@@ -43,11 +43,11 @@ STRING_VALUE (LIT_MAGIC_STRING_NAME,
  *  (property name, C routine name, arguments number or NON_FIXED, value of the routine's length property) */
 
 /* ES2015 24.1.3.1 */
-ROUTINE (LIT_MAGIC_STRING_IS_VIEW_UL, ecma_builtin_arraybuffer_object_is_view, 1, 1)
+ROUTINE (LIT_MAGIC_STRING_IS_VIEW_UL, ECMA_BUILTIN_ARRAYBUFFER_OBJECT_IS_VIEW, 1, 1)
 
 /* ES2015 24.1.3.3 */
 ACCESSOR_READ_ONLY (LIT_GLOBAL_SYMBOL_SPECIES,
-                    ecma_builtin_arraybuffer_species_get,
+                    ECMA_BUILTIN_ARRAYBUFFER_SPECIES_GET,
                     ECMA_PROPERTY_FLAG_CONFIGURABLE)
 
 #endif /* JERRY_BUILTIN_TYPEDARRAY */