Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix percentiles aggregation type in Spike Metric Aggregation rules #1323

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Fix percentiles aggregation type in Spike Metric Aggregation rules #1323

merged 2 commits into from
Nov 29, 2023

Conversation

jertel
Copy link
Owner

@jertel jertel commented Nov 29, 2023

Description

Corrects a logic flaw and typo for Spike Metric Aggregation rules using the percentiles aggregation.

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

@nsano-rururu nsano-rururu merged commit 8713ab3 into master Nov 29, 2023
1 check passed
@jertel jertel deleted the jertel/percentiles branch December 3, 2023 14:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nsano-rururu nsano-rururu nsano-rururu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jertel @nsano-rururu