Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dynamic values via field substitution for the opsgenie_addr field #1563

Merged
merged 6 commits into from
Nov 11, 2024

Conversation

mohamedelema17
Copy link
Contributor

@mohamedelema17 mohamedelema17 commented Nov 9, 2024

Description

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

Unit test is not necessary as the current tests sufficiently cover this small change.

opsgenie_addr now allows formatted field and the documentation is  updated to reflect this as well as an example provided
…matched field

Discussion regarding this can be found here. jertel#1561
@jertel
Copy link
Owner

jertel commented Nov 10, 2024

Thanks for the submission. Unit tests are required, even for this small change. It should be possible to modify an existing test to prove that the to_addr is dynamically updated with the match data.

@mohamedelema17
Copy link
Contributor Author

@jertel I have added the unit test

@jertel
Copy link
Owner

jertel commented Nov 11, 2024

Thank you. It looks like the build failed due to some whitespace linting checks. Please review the build output. Once you get this to pass we can get it merged in. make test-docker will give the same failure and results, so you can use that to verify before you push.

@jertel
Copy link
Owner

jertel commented Nov 11, 2024

One more:

 ./alerters/opsgenie_test.py:1275:39: E231 missing whitespace after ','

@jertel jertel merged commit bb21503 into jertel:master Nov 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants