Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix returned type around datetime #1594

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Conversation

thican
Copy link
Contributor

@thican thican commented Dec 22, 2024

Description

Fix commit 9851ca6 from PR #424, it resolves some linter error reporting.

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • [ ] I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

Commit from quite some time, so I am not able today to recreate the test environment, hence why I did not run test through Docker.
However because it does not modify any actual instruction, it should not have any impact.
And no documentation update required.

@jertel
Copy link
Owner

jertel commented Dec 22, 2024

Thanks for that correction. Will you please update the CHANGELOG with the fix?

fix: 9851ca6

Signed-off-by: Thibaud CANALE <thican@thican.net>
@thican thican force-pushed the dev/fix_data_reading branch from fdfd399 to 1e0a770 Compare December 22, 2024 23:32
@thican
Copy link
Contributor Author

thican commented Dec 22, 2024

Okay done, but I think it was better to not update CHANGELOG for this, as it has no impact on instruction because Python language does not check type during runtime (not 100% sure tho).

@jertel jertel merged commit 858f9cc into jertel:master Dec 23, 2024
1 check passed
@thican thican deleted the dev/fix_data_reading branch December 23, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants