Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Guava #114

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Remove Guava #114

merged 2 commits into from
Jun 13, 2024

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Jun 12, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new
    tests.

Following jfrog/build-info#793.
The tests for MacOS will not pass before merging this PR. See the tests passed here - https://github.com/yahavi/artifactory-gradle-plugin/actions/runs/9484215197/job/26133193344.
Remove Guava entirely from this plugin.
Replace Guava's ArrayListMultimap with Apache Commons collection's ArrayListValuedHashMap.

@yahavi yahavi added the improvement Automatically generated release notes label Jun 12, 2024
@yahavi yahavi self-assigned this Jun 12, 2024
@yahavi yahavi deployed to frogbot June 12, 2024 14:16 — with GitHub Actions Active
@yahavi yahavi added the safe to test Approve running tests on a pull request label Jun 12, 2024
@github-actions github-actions bot removed the safe to test Approve running tests on a pull request label Jun 12, 2024
@yahavi yahavi requested a review from eyalbe4 June 12, 2024 14:19
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


@yahavi yahavi requested a review from RobiNino June 13, 2024 05:53
.github/workflows/test.yml Show resolved Hide resolved
@yahavi yahavi merged commit 16c865e into jfrog:main Jun 13, 2024
2 of 3 checks passed
@yahavi yahavi deleted the remove-guava branch June 13, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants