Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors use "bs-form-invalid-color" instead of red #717

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

BryceStevenWilley
Copy link
Contributor

Makes the error colors shown to the user a bit more cohesive. Additionally, straight red doesn't have enough contrast with the default dark mode to pass WCAG AA.

Only changes docassemble's CSS, so it shouldn't affect people who are already overriding the color.

Some images to show the new color.

Screenshot from 2023-12-01 15-22-34

Screenshot from 2023-12-01 15-29-20

Makes thing be a bit more cohesive in terms of error colors shown to the user,
and straight red doesn't have enough contrast with the default dark mode.

Only changes docassemble's CSS, so it shouldn't affect people who are already
overriding the color.
@jhpyle jhpyle merged commit 21a9ad0 into jhpyle:master Dec 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants