Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Slot Monotic Constraint #109

Closed
wants to merge 2 commits into from
Closed

Remove Slot Monotic Constraint #109

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b2bed1
remove slot monotic restraint
jedleggett Feb 21, 2024
d5255fe
Merge branch 'master' into jl/remove_monotonic_slot
jedleggett Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions rpc/src/load_balancer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,13 +114,10 @@ impl LoadBalancer {
);

{
let old_slot = highest_slot.fetch_max(slot.slot, Ordering::Relaxed);
if slot.slot > old_slot {
if let Err(e) = slot_sender.send(slot.slot)
{
error!("error sending slot: {e}");
break;
}
if let Err(e) = slot_sender.send(slot.slot)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not going to work super well if RPCs are running behind. note the following graph from our internal + external RPC cluster:
Screenshot 2024-02-21 at 11 16 42 AM

{
error!("error sending slot: {e}");
Copy link
Contributor

@esemeniuc esemeniuc Feb 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
error!("error sending slot: {e}");
error!("error sending slot {}: {e}", slot.slot);

break;
}
}
}
Expand Down
Loading