Fw preset workarounds #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if output is already off, if a fault is present call the API to attempt to clear the fault.
DP100 v1.4 turns the output on when transitioning from preset 0 to another preset. This is likely a bug since other preset transitions will turn the output off, which is a much safer behavior for such a device to exhibit. To emulate this behavior a workaround has been implemented where, the preset will not be applied until the user requests that the output be turned on. This behavior should only apply when in teh power-ON preset 0 state.
This change attempts to mitigate OCP faults when switching presets, while keeping the loss of responsiveness to a minimum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #17 , a potentially dangerous issue with either the AlientTek's DP100 DLL or their device FW v1.4.
However, this means there will be a limitation on using the CLI's
--presetoption while the device is in preset 0.The following will not behave as a user may expect
This will result in:
The observed behavior is:
If it is desired for the preset value to actually change during the command the user must use the
--oncommand.However, a further stipulation here is that the
--oncommand must be issued after setting--presetto a value between (inclusive) 1-9.For example:
Once the device has left preset 0. The device behavior will follow a more logical behavior.
This PR also mitigates the issue with OCP false triggers, "sufficiently" closing #5.