Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create issue templates for PyBaseball project. #312

Closed
wants to merge 3 commits into from
Closed

Create issue templates for PyBaseball project. #312

wants to merge 3 commits into from

Conversation

BrayanMnz
Copy link
Contributor

Creating the template for PyBaseball project,
initially we're just using some of the default options provided by Github.

Creating the template for PyBaseball project, 
initially we're just using some of the default options provided by Github.
Create issue templates for PyBaseball project.
Copy link
Collaborator

@tjburch tjburch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My personal ethos is that we should make it as easy as possible for people to submit an issue, and these have a tendency to add another hoop to jump through, so I'm not 100% sold on issue templates. However, if the community wants it, I'm happy to add it.

I think removing some of the redundancy as mentioned in the review so it's just very quick "tell me your problem and your setup" would help it feel less like a hurdle.

**Expected behavior**
A clear and concise description of what you expected to happen.

**Screenshots**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know about others but I personally dislike screenshots in issues. Would rather see the copy/pasted error message as-is.

3. Scroll down to '....'
4. See error

**Expected behavior**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO I think the first three forms here are going to most often yield the same thing 3 times over and over: "I expected this to happen when I did this." I'd prefer one simpler form, something like

***Describe the bug and how to produce it***

about: Create a report to help us improve
title: PYBASEBALL-BUG-
labels: ''
assignees: ''
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove assignees. If things get assigned, I think that should be done by maintainers or whomever wants to do it, I'd rather not have the submitter choose who.

**Desktop (please complete the following information):**
- OS: [e.g. Ubuntu, Windows]
- Python version [e.g. 3.7, 3.9]

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add:

- pybaseball version (e.g. 2.2.3, 2.2.4, or development if a direct clone)

I think this also motivates merging #295 to make this more accessible.

@BrayanMnz BrayanMnz closed this by deleting the head repository Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants