Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chart: Add namespace to Service and ServiceMonitor #116

Merged
merged 1 commit into from
Sep 6, 2024
Merged

chart: Add namespace to Service and ServiceMonitor #116

merged 1 commit into from
Sep 6, 2024

Conversation

jplitza
Copy link
Contributor

@jplitza jplitza commented Sep 6, 2024

No description provided.

@jmcgrath207
Copy link
Owner

Hi @jplitza,

Helm should inject the namespace property into those manifests. Are you not seeing that behavior?

@jplitza
Copy link
Contributor Author

jplitza commented Sep 6, 2024

@jmcgrath207 It does, when using helm install. I used helm template and kubectl, in which case it doesn't. ;)

All other files contain that exact line, so I thought I might as well open a PR.

@jmcgrath207 jmcgrath207 merged commit 916fe0f into jmcgrath207:master Sep 6, 2024
1 check passed
@jmcgrath207
Copy link
Owner

Gotcha, thanks for going into detail @jplitza

I merged it and will release it later today.

Thanks!

@jmcgrath207
Copy link
Owner

Your change is live in release 1.12.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants