Make ServiceAccount & RBAC configurable #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RobinSchwaller Thanks for adding this feature; for some reason, it's failing the e2e test. I'm short on time today, but I'll be sure to troubleshoot this more in-depth tomorrow and let you know. |
|
@jmcgrath207, thanks for checking the e2e test. Just to let you know, I missed some stuff in my initial commit; maybe this already solves it. 😅 |
|
@RobinSchwaller No worries and thanks for fixing that. I fixed up the merge conflict and will release it soon. |
|
Your change is live in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137