Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pod_namespace to the metrics #2

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

FUSAKLA
Copy link
Contributor

@FUSAKLA FUSAKLA commented Jul 17, 2023

Hi @jmcgrath207, firstly, thanks for the useful tool!

We just miss information about the namespace of the pod, so this PR adds it as pod_name.

Tested locally and works fine

ephemeral_storage_pod_usage{node_name=row-x-y1-40c48r600d-b6675bfc5-c75mh",pod_name="calico-node-ghljj",pod_namespace="calico-system"} 4.069376e+07

Additionally, I just added tiny changes in logging and go mod tidy in separate commits.

FUSAKLA added 3 commits July 17, 2023 12:02
Signed-off-by: Martin Chodur <m.chodur@seznam.cz>
Signed-off-by: Martin Chodur <m.chodur@seznam.cz>
Signed-off-by: Martin Chodur <m.chodur@seznam.cz>
@jmcgrath207 jmcgrath207 merged commit 74b486a into jmcgrath207:master Jul 17, 2023
@jmcgrath207
Copy link
Owner

Thanks, @FUSAKLA! Your change looks excellent, and I merged it.

FWIW, I am planning on adding image/chart hosting and e2e testing later this week

#3
#4

@FUSAKLA
Copy link
Contributor Author

FUSAKLA commented Jul 17, 2023

Oh, cool! We are currently building our own container internally, but would be happy to mirror an officially released build :) 👍

@FUSAKLA
Copy link
Contributor Author

FUSAKLA commented Jul 17, 2023

Also thanks for such quick reaction! 🙏

@FUSAKLA FUSAKLA deleted the fus-namespace branch July 17, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants