Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix node eviction when scaling down. #66

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

jmcgrath207
Copy link
Owner

@jmcgrath207 jmcgrath207 commented Mar 25, 2024

Fixes #64

There was a bug where nodes were not being evicted when scaling down.

This change also includes:

  • Scale up and down e2e test
  • Fixed flakiness on the minikube registry
  • refactor for grow and shrink e2e test.

@jmcgrath207 jmcgrath207 reopened this Mar 25, 2024
@jmcgrath207 jmcgrath207 changed the title bug: fix node eviction bug: fix node eviction and added scale up and down node test. Mar 25, 2024
@jmcgrath207 jmcgrath207 force-pushed the fix-removed-nodes branch 4 times, most recently from 751aceb to 4667c9e Compare March 25, 2024 02:33
@jmcgrath207 jmcgrath207 changed the title bug: fix node eviction and added scale up and down node test. bug: fix node eviction when scaling down. Mar 25, 2024
@jmcgrath207 jmcgrath207 merged commit 9758c1d into master Mar 25, 2024
3 checks passed
@jmcgrath207 jmcgrath207 deleted the fix-removed-nodes branch March 31, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removed Nodes still emitting metrics
1 participant