Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #514 #515

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Fix #514 #515

merged 2 commits into from
Dec 5, 2023

Conversation

Chaphasilor
Copy link
Collaborator

Fixes the "shuffle always starts on first song" issue in the same way as originally done in #442

@Chaphasilor Chaphasilor linked an issue Oct 21, 2023 that may be closed by this pull request
@Chaphasilor
Copy link
Collaborator Author

I added the fix for albums and playlists as well, but it seems like there is a conflict between fixing this and fixing #482 😕
I personally cannot reproduces the issue from that other issue, but we should try to test for it before merging my PR...

@Chaphasilor Chaphasilor changed the title Fix #61 on artist page Fix #514 Oct 21, 2023
@Chaphasilor Chaphasilor self-assigned this Nov 28, 2023
@Chaphasilor
Copy link
Collaborator Author

Given that there are still issues with shuffle starting on the first track (see #545), I'll merge this in for now. Unless something severely breaks, this will likely stay in place until the redesign hits stable...

@Chaphasilor Chaphasilor merged commit ae59923 into jmshrv:main Dec 5, 2023
2 checks passed
@Chaphasilor Chaphasilor deleted the fix-61-artist-page branch December 5, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shuffle on Artist does not queue correct
1 participant