-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix touch support. #169
base: master
Are you sure you want to change the base?
Fix touch support. #169
Conversation
…ntDefault on drag, not on mousedown/touchstart.
I have not recompiled the minified version of the script. I assume you have a process for doing that. |
@@ -86,6 +86,7 @@ | |||
// The Placeholder has not been moved yet. | |||
onDrag: function ($item, position, _super, event) { | |||
$item.css(position) | |||
event.preventDefault() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On mobile, this prevents the page from scrolling while dragging an object.
Hi, thanks for the patch but I've got a problem with it: On touch devices like iPad or Android I experienced a problem: Clicking on links works now with your patch, also the dragging works, but when dropping the link is clicked instead of firing the onDrop event. Any idea? |
Hmm, I'm not sure. Feel free to investigate. I didn't end up using this library for the feature I was working on, after all, so I don't have a lot invested in debugging this anymore. |
Fix touch support. #169 for jquery-sortable Fix touch support. In case we are dragging something clickable, preventDefault on drag, not on mousedown/touchstart by collinstocks. johnny/jquery-sortable#169 This is support for FirefoxOS
Hi. This is great Fix! |
If anyone is having this error in console : Just add |
@devmotionfr I've used |
Fix touch support. In case we are dragging something clickable, preventDefault on drag, not on mousedown/touchstart.