Futures WIP #72
Open
Futures WIP #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, I'm not really doing much C++ these days. How's the situation when it comes to unit testing etc? Any chance we (or rather: you) could put some tests in place for this? There are no existing tests to lean on unfortunately, so maybe that's too much effort? Otherwise, let me know if you do some more manual testing on this and feel confident enough for me to merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the possibility to return QVariant futures in the services.
Futures uses QFuture therefore runs in a different thread (or the QThreadPool specified as second argument, useful to simulate a queue if you limit the pool to 1) therefore shared variables access must be handled correctly.
QFutures cannot really be cancelled by design but client disconnection is handled correctly.
This is just a POC and not well tested yet.