Skip to content

Commit

Permalink
Fixed login and add button colour on iOSUpdate (#65)
Browse files Browse the repository at this point in the history
* Fixed login and add button colour on iOS

On iOS the login and add buttons (add bookmark, add note) text was not
visible, showing only the outline of the button. This change sets an
excplicit colour for the button text `black-70`. The choice among
tachyon classes here is arbitrary and could be styled differently
according to preference.

* set submit button fg color; update js output

---------

Co-authored-by: NSBum <duncan.alan@me.com>
  • Loading branch information
jonschoning and NSBum authored Dec 30, 2024
1 parent 50fbf47 commit c92ae60
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 11 deletions.
10 changes: 5 additions & 5 deletions purs/src/Component/Add.purs
Original file line number Diff line number Diff line change
Expand Up @@ -130,14 +130,14 @@ addbmark b' =
]
, tr_
[ td_ [ ]
, td_ [ input [ type_ InputSubmit , class_ "ph3 pv2 input-reset ba b--navy bg-transparent pointer f6 dib mt1 dim"
, td_ [ input [ type_ InputSubmit , class_ "ph3 pv2 input-reset black ba b--navy bg-transparent pointer f6 dib mt1 dim"
, value (if bm.bid > 0 then "update bookmark" else "add bookmark") ] ]
]
]
]
]

display_exists _ =
display_exists _ =
div [ class_ "alert" ]
[ text "previously saved "
, span [ class_ "link f7 dib gray pr3" , title (maybe bm.time snd mmoment) ]
Expand All @@ -148,12 +148,12 @@ addbmark b' =
, span ([ class_ "confirm red" ] <> guard (not s.deleteAsk) [ attr "hidden" "hidden" ])
[ button [ type_ ButtonButton, onClick \_ -> BDeleteAsk false] [ text "cancel / " ]
, button [ type_ ButtonButton, onClick \_ -> BDestroy, class_ "red" ] [ text "destroy" ]
]
]
]
]
]

alert_notification alert_text _ =
alert_notification alert_text _ =
div [ class_ "alert alert-err" ] [ text alert_text ]

display_destroyed _ = p [ class_ "red"] [text "you killed this bookmark"]
Expand Down Expand Up @@ -195,7 +195,7 @@ addbmark b' =

handleAction (BEditSubmit e) = do
liftEffect (preventDefault e)
edit_bm <- use _edit_bm
edit_bm <- use _edit_bm
_apiError .= Nothing
H.liftAff (editBookmark edit_bm) >>= case _ of
Left affErr -> do
Expand Down
2 changes: 1 addition & 1 deletion static/js/app.min.js

Large diffs are not rendered by default.

Binary file modified static/js/app.min.js.gz
Binary file not shown.
4 changes: 2 additions & 2 deletions static/js/app.min.js.map

Large diffs are not rendered by default.

Binary file modified static/js/app.min.js.map.gz
Binary file not shown.
2 changes: 1 addition & 1 deletion templates/change-password.hamlet
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@
<label .db.fw6.lh-copy.f6 for="newpassword">New Password
<input #newpassword .w-100.pa1.mb2.ba.b--black-20 required name="newpassword" type="password">

<input class="ph3 pv2 input-reset ba b--navy bg-transparent pointer f6 dib mt3 dim" type="submit" value="Save Changes">
<input class="ph3 pv2 input-reset black ba b--navy bg-transparent pointer f6 dib mt3 dim" type="submit" value="Save Changes">
4 changes: 2 additions & 2 deletions templates/login.hamlet
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<div>
<label .db.fw6.lh-copy.f6 for="password">Password
<input #password .w-100.pa1.mb2.ba.b--black-20 name="password" type="password">
<input class="ph3 pv2 input-reset ba b--navy bg-transparent pointer f6 dib mt3 dim" type="submit" value="Log In">

<input class="ph3 pv2 input-reset black ba b--navy bg-transparent pointer f6 dib mt3 dim" type="submit" value="Log In">

<script> document.body.classList.add("bg-near-white");

0 comments on commit c92ae60

Please sign in to comment.