Skip to content
This repository has been archived by the owner on Jul 28, 2020. It is now read-only.

Minor UI changes #163

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

ravisaxena23
Copy link

Pull Request for Issue- Not related to any but important .

Summary of Changes

  1. Added customized scroll bar that matches the theme hence enhancing the look.
  2. Made cards corners round that look good.
  3. while studying the code Added I added few comments that help in understanding code
  4. updated readme.md so that one can now what is joomla.

Testing Instructions

  1. Can open Using Chrome or any browser.
  2. Remember I'm a Noob(no shame accepting it) and trying to learn things please give me a feedback and what i can improve

Expected result

  1. customized scroll bar.
  2. cards corner should be round.
    Screenshot (93).

Actual result

  1. customized scroll bar.
  2. cards corner should be round

Documentation Changes Required

No.

@kawshar
Copy link
Contributor

kawshar commented Dec 13, 2019

Round corner does not go with the whole concept of this interface. I would like to suggest that we should work on the design files instead of the code in terms of design changes. I can share the sketch file if you want.

Thank you

@ravisaxena23
Copy link
Author

yes I would really appreciate that . please send me to saxenaravi23599@gmail.com .

@@ -65,7 +65,44 @@
opacity: 0;
}
';
// $this->addStyleDeclaration($css);
$scroll ='
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this going in the index.php?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be not there?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be in a SCSS file

@ravisaxena23
Copy link
Author

ravisaxena23 commented Dec 16, 2019

Round corner does not go with the whole concept of this interface. I would like to suggest that we should work on the design files instead of the code in terms of design changes. I can share the sketch file if you want.

Thank you

hello sir i din't get the map can you please share it with me on saxenaravi23599@gmail.com

@kawshar
Copy link
Contributor

kawshar commented Dec 17, 2019

@ravisaxena23 please allow me couple of days.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants