Skip to content

Commit

Permalink
Merge pull request #9 from jorenham/basedpyright
Browse files Browse the repository at this point in the history
Better type-checking with basedpyright
  • Loading branch information
jorenham authored Aug 19, 2024
2 parents 1a3ee75 + aee3a39 commit 5b41312
Show file tree
Hide file tree
Showing 3 changed files with 39 additions and 29 deletions.
10 changes: 8 additions & 2 deletions .github/workflows/CI.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,14 @@ jobs:
- name: codespell
run: poetry run codespell .

- name: pyright
run: poetry run pyright
- name: codespell
run: poetry run ruff check --output-format=github

- name: basedpyright
run: poetry run basedpyright

- name: basedpyright --verifytypes
run: poetry run basedpyright --ignoreexternal --verifytypes exports

- name: pytest
run: poetry run pytest
51 changes: 26 additions & 25 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ classifiers = [
]
repository = "https://github.com/jorenham/exports"
documentation = "https://github.com/jorenham/exports/blob/master/README.md"
packages = [{include = "exports"}] # don't remove

[tool.poetry.urls]
"Bug Tracker" = "https://github.com/jorenham/exports/issues"
Expand All @@ -32,8 +33,8 @@ documentation = "https://github.com/jorenham/exports/blob/master/README.md"
python = "^3.8"

[tool.poetry.group.dev.dependencies]
basedpyright = "^1.16.0"
codespell = "^2.3.0"
pyright = "^1.1.376"
pytest = "^8.3.2"
ruff = "^0.6.1"

Expand All @@ -51,7 +52,9 @@ venvPath = "."
venv = ".venv"
pythonVersion = "3.8"
pythonPlatform = "All"
typeCheckingMode = "strict"
typeCheckingMode = "all"

reportUnusedCallResult = false # https://github.com/microsoft/pyright/issues/8650


[tool.pytest.ini_options]
Expand Down

0 comments on commit 5b41312

Please sign in to comment.