-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use uv
as package manager
#174
Conversation
Thanks a lot for this! |
What are the advantages for using |
FYI, I also tried migrating this to uv a while back: But for some reason I wasn't able to get it to work 🤔. My guess is that it has to do with either hatch or uv itself not supporting stub-only packages. And although I haven't verified this, I suspect this has to do with the |
Yeah, I see the problem. I think it's related to how Going back to the choice between |
Ok that makes sense 👌🏻. I'm not familiar with BTW, don't forget update the |
The contribution docs should be sorted now. The things I think are worth considering in this PR are:
|
Hmm, I see what you mean, but I usually try to minimize the amount of (config) files in the repo root. Having a central place for configuration can also be helpful in my experience, which can be especially practical when we change a config option that affects multiple tools (e.g. mypy and pyright). Perhaps it could help if we'd add a comment between sections, so that they're easier to visually distinguish 🤔 |
Hmm, I see that Oh and speaking of GHA, the In the meantime I upgraded ruff and fixed the new errors, which is what's causing the merge conflicts, as this PR also included some fixes for those ruff errors. Anyway; there's no need to worry about those ruff errors now; and you can just reset those
That sounds interesting; looking forward to it :)
My gut feeling tells me it has something to do with hatch (and I based that on totally nothing 👌🏻). So perhaps switching to another build tool could help with this? |
just to throw another hat into the ring 😅 with https://pixi.sh this would look like Probably good to migrate to |
There's also |
|
@miloth I also don't mind merging the UV part of this PR as it currently is. We could then reconsider replacing |
Hi @jorenham , I've just come back from a long work trip, no real time to do some fun coding. I'll clean it up next week if you want. Or feel free to do as you suggested in the meantime! |
No worries; I'm just happy to see that you're still interested :) In the meantime some merge conflicts have accumulated, but those shouldn't be difficult to deal with.
What suggestion of mine are you referring to here? |
1768a9c
to
a8a8141
Compare
ab3e82c
to
5bfd09d
Compare
02bf49a
to
42614af
Compare
uv
using just
to run commandsuv
as package manager
Thanks @miloth! |
Hi @jorenham , this aims at solving #49. The main changes are:
uv
.Command runner changed to.just
tox
andpre-commit
useuv
as venv backend.It is a proof of concept, untested on GHA, hence the "draft" status. I just wanted to check if changing the command runner was an acceptable trade-off before continuing the work.Resolves #49