Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Jackson 2.18.2 #173

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Conversation

thetric
Copy link

@thetric thetric commented Dec 17, 2024

Superceds #167, #172. Fixes #166

@thetric
Copy link
Author

thetric commented Dec 23, 2024

One test class to go 🥳

pom.xml Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@thetric
Copy link
Author

thetric commented Jan 5, 2025

Ah, I now understand why the tests failed. Upstream has introduced a new Jackson module JavaTimeModule as a replacement for JSR310Module which configures some settings slightly different. Additionally, there is now an old package for the deprecated JSR310Module

@thetric thetric marked this pull request as ready for review January 5, 2025 17:07
public final class ThreeTenModule extends SimpleModule
{
@Deprecated // since 2.18
public final class ThreeTenModule extends SimpleModule {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated in favor of ThreeTenTimeModule

@thetric
Copy link
Author

thetric commented Jan 8, 2025

Hm, this seems to be an issue with Java 8. The other versions just work fine?

@joschi
Copy link
Owner

joschi commented Jan 9, 2025

Hm, this seems to be an issue with Java 8. The other versions just work fine?

Any idea what's causing the difference? The purpose of this library is supporting older Java versions, after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create new release
3 participants