fix: #3342 hexadecimal input not turned into a bigint

josdejong · Jan 8, 2025 · 646126d · 646126d
1 parent 29abd17
commit 646126d
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/src/utils/number.js b/src/utils/number.js
@@ -48,8 +48,16 @@ export function isIntegerStr (str) {
  * @returns {'number' | 'BigNumber' | 'bigint' | 'Fraction'}
  */
 export function safeNumberType (numberStr, config) {
-  if (config.number === 'bigint' && !isIntegerStr(numberStr)) {
-    return config.numberFallback
+  if (config.number === 'bigint') {
+    const canParseIntoBigint =
+      isIntegerStr(numberStr) ||
+      numberStr.startsWith('0x') ||
+      numberStr.startsWith('0b') ||
+      numberStr.startsWith('0o')
+
+    if (!canParseIntoBigint) {
+      return config.numberFallback
+    }
   }
 
   return config.number

diff --git a/test/unit-tests/expression/parse.test.js b/test/unit-tests/expression/parse.test.js
@@ -2248,6 +2248,12 @@ describe('parse', function () {
       assert.strictEqual(bigmath.evaluate('-2.3'), -2.3)
     })
 
+    it('should parse hex, bin, oct numbers as bigint', function () {
+      assert.strictEqual(bigmath.evaluate('0xA2'), 162n)
+      assert.strictEqual(bigmath.evaluate('0b1011'), 11n)
+      assert.strictEqual(bigmath.evaluate('0o70'), 56n)
+    })
+
     it('should fallback on the configured numberFallback when parsing as bigint', function () {
       const bigmathFallback = math.create({
         number: 'bigint',