Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Riemann Zeta Function Implemented #2950
base: develop
Are you sure you want to change the base?
Riemann Zeta Function Implemented #2950
Changes from 5 commits
23b4819
b67e2c3
0c4aea5
c507716
1db74c1
3ddb7dc
19cbf65
dc7db48
f1fa319
59290c5
19aae26
2e67f57
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be a more informative description for the property
s
than "A real or complex number"? (missing BigNumber right now)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fixed now in the newest commits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😂 well it's technically OK now. What I meant is that the description is not really a description, it only tells the type of
s
, but that is already documented.It's like when you ask me "what do you have there?" and my answer is "steel and plastic". That can be technically correct. But a more helpful answer would be "a screwdriver". Explaining what kind of thing it is or what meaning it has.
Not a big deal though. I can't come up with something meaningful. Maybe "The numeric input for the zeta function" or so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see what you are saying, sorry for the misunderstanding. I think I can come up something more descriptive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not result in a true BigNumber version of
pi
. I think you can simply importpi
instead? Or use the functioncreateBigNumberPi
?