Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Riemann Zeta Function Implemented #2950
base: develop
Are you sure you want to change the base?
Riemann Zeta Function Implemented #2950
Changes from 1 commit
23b4819
b67e2c3
0c4aea5
c507716
1db74c1
3ddb7dc
19cbf65
dc7db48
f1fa319
59290c5
19aae26
2e67f57
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Matlab and Mathematica for example you can use
zeta
. I see in your unit tests you prefer this short namezeta
too. Is it an idea to just name the functionzeta
instead ofriemannZeta
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I named it riemannZeta since there are a bunch of zeta functions out there that I didn't want to confuse with such as the Hurwitz Zeta function. Since the Riemann zeta is the most well known of the zeta functions I think it's okay to rename it to zeta and if subsequent zeta functions are implement to name them hurwitzZeta etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good point to make sure there will be no confusion. As far as I can see, Matlab uses
zeta
, Mathematica allows bothzeta
andriemannZeta
, and Python combines both Riemann and and Hurwitz in a single functionzeta
, defaulting to Riemann (I personally would prefer to have two separate functions).I'm OK with either one, what do you think is best?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think zeta is more concise and most people will think of riemannZeta when looking at zeta. I have no idea how to implement a fast algorithm for the Hurwitz zeta function but I agree making them separate makes the most sense. Let's switch to just zeta
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 sounds good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still planning on renaming the function and files
zeta
?