Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Make AlexaHandles.onTask global #1608

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

sadlowskij
Copy link
Contributor

Proposed Changes

This adds the global flag to the onTask HanldeOptions, so the user won't have to manually add this, in case the handler is not placed in a global Component. This is the example request from the docs:

{
    "type": "LaunchRequest",
    "requestId": "string",
    "timestamp": "string",
    "locale": "string",
    "task": {
        "name": "AMAZON.PrintPDF",
        "version": "1",
        "input": {
            "@type": "PrintPDFRequest",
            "@version": "1",
            "title": "Flywheel",
            "description": "Flywheel",
            "url": "http://www.example.com/flywheel.pdf"
        }
    }
}

As can be seen, a task comes in with a LaunchRequest, therefore should never be possible within a session. This is why I think it'd be easier to already include the global flag in the onTask function.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@sadlowskij sadlowskij changed the title V4/bug/global alexa on task 🔧 Make AlexaHandles.onTask global Dec 20, 2023
@sadlowskij
Copy link
Contributor Author

I pushed commit 08b0ffe on the wrong branch by mistake, which is why I instantly reverted it in this branch and pr. This is a seperate issue :)

Copy link
Member

@jankoenig jankoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jankoenig jankoenig merged commit 64d4e10 into jovotech:v4/dev Jan 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants