save cover size to db

app/Images/Cover.php

@@ -3,18 +3,32 @@
 namespace App\Images;
 
 use App\Models\Tale;
+use Exception;
 use Illuminate\Database\Eloquent\Relations\HasMany;
 use Intervention\Image\Interfaces\ImageInterface;
 
 final class Cover extends Image
 {
+    protected $casts = [
+        'size' => 'int',
+    ];
+
     public function processVariant(ImageInterface $image, string $variant): ImageInterface
     {
         $size = min($image->width(), $image->height());
 
         return $image->cover($size, $size);
     }
 
+    public function saveDimensions(int $width, int $height): void
+    {
+        if ($width !== $height) {
+            throw new Exception('Expected tale cover to be square.');
+        }
+
+        $this->size = $width;
+    }
+
     protected static function pathPrefix(): string
     {
         return 'covers';

app/Images/Image.php

@@ -33,6 +33,8 @@ abstract protected static function pathPrefix(): string;
 
     abstract public function processVariant(ImageInterface $image, string $variant): ImageInterface;
 
+    abstract public function saveDimensions(int $width, int $height): void;
+
     /**
      * @return list<string>
      */
@@ -178,9 +180,4 @@ public static function disk(): FilesystemAdapter
     {
         return Storage::disk(config('filesystems.media'));
     }
-
-    public static function shouldSaveDimensions(): bool
-    {
-        return false;
-    }
 }

app/Images/Jobs/ProcessImage.php

@@ -43,11 +43,8 @@ public function processVariant(string $variant): void
 
         $this->image->processVariant($image, $variant);
 
-        if ($variant === 'default' && $this->image::shouldSaveDimensions()) {
-            /** @phpstan-ignore property.notFound */
-            $this->image->width = $image->width();
-            /** @phpstan-ignore property.notFound */
-            $this->image->height = $image->height();
+        if ($variant === 'default') {
+            $this->image->saveDimensions($image->width(), $image->height());
         }
 
         $destinationPath = $this->image->variantPath($variant);

app/Images/Photo.php

@@ -43,6 +43,12 @@ public function processVariant(ImageInterface $image, string $variant): ImageInt
         return $this->grayscale ? $image->greyscale() : $image;
     }
 
+    public function saveDimensions(int $width, int $height): void
+    {
+        $this->width = $width;
+        $this->height = $height;
+    }
+
     protected static function pathPrefix(): string
     {
         return 'photos';
@@ -53,11 +59,6 @@ public function crop(): ArtistPhotoCrop
         return $this->crop;
     }
 
-    public static function shouldSaveDimensions(): bool
-    {
-        return true;
-    }
-
     public function artists(): HasMany
     {
         return $this->hasMany(Artist::class, 'photo_filename', 'filename');

database/migrations/2024_10_06_124745_add_size_to_covers_table.php

@@ -0,0 +1,14 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
+
+return new class extends Migration {
+    public function up(): void
+    {
+        Schema::table('covers', function (Blueprint $table) {
+            $table->integer('size')->nullable();
+        });
+    }
+};

tests/Unit/Images/CoverProcessingTest.php

@@ -38,13 +38,15 @@ public function testItWorks(): void
     {
         Cover::disk()->assertExists("covers/original/{$this->filename}");
         Cover::disk()->assertMissing("covers/default/{$this->filename}");
+        $this->assertNull($this->cover->size);
         $this->assertNull($this->cover->placeholder());
 
         ProcessImage::dispatchSync($this->cover);
 
         $this->cover->refresh();
         Cover::disk()->assertExists("covers/original/{$this->filename}");
         Cover::disk()->assertExists("covers/default/{$this->filename}");
+        $this->assertSame(427, $this->cover->size);
         $this->assertStringStartsWith('data:image/svg+xml;base64,', $this->cover->placeholder());
     }
 }

tests/Unit/Images/CoverTest.php

@@ -19,6 +19,12 @@ public function testVariants(): void
         $this->assertSame(['default'], Cover::variants());
     }
 
+    #[TestDox('it casts size to integers')]
+    public function testSizeCast(): void
+    {
+        $this->assertSame(2137, (new Cover(['size' => '2137']))->size);
+    }
+
     #[TestDox('it stores new cover in correct path and dispatches necessary jobs to process it')]
     public function testStore(): void
     {

tests/Unit/Images/PhotoProcessingTest.php

@@ -43,6 +43,8 @@ public function testItWorks(): void
         Photo::disk()->assertExists("photos/original/{$this->filename}");
         Photo::disk()->assertMissing("photos/default/{$this->filename}");
         Photo::disk()->assertMissing("photos/face/{$this->filename}");
+        $this->assertNull($this->photo->width);
+        $this->assertNull($this->photo->height);
         $this->assertNull($this->photo->placeholder());
         $this->assertNull($this->photo->placeholder('face'));
 

tests/Unit/Images/TestCover.php

@@ -16,6 +16,10 @@ public function processVariant(ImageInterface $image, string $variant): ImageInt
         return $image->cover($size, $size);
     }
 
+    public function saveDimensions(int $width, int $height): void
+    {
+    }
+
     protected static function pathPrefix(): string
     {
         return 'covers';