fixed some code quality issues

jrnd-io · Dec 7, 2023 · e28096a · e28096a
1 parent cb1adc9
commit e28096a
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 9 deletions.
diff --git a/pkg/producers/elastic/elasticProducer.go b/pkg/producers/elastic/elasticProducer.go
@@ -32,6 +32,9 @@ func (p *ElasticProducer) Initialize(configFile string) {
 	var config Config
 	file, err := ioutil.ReadFile(configFile)
 	err = json.Unmarshal(file, &config)
+	if err != nil {
+        log.Fatalf("Failed to ReadFile: %s", err)
+    }
 	if err != nil {
 		log.Fatalf("Failed to parse configuration parameters: %s", err)
 	}

diff --git a/pkg/producers/mongoDB/mongoProducer.go b/pkg/producers/mongoDB/mongoProducer.go
@@ -27,6 +27,9 @@ type MongoProducer struct {
 func (p *MongoProducer) Initialize(configFile string) {
 	var config Config
 	file, err := ioutil.ReadFile(configFile)
+	if err != nil {
+    	log.Fatalf("Failed to ReadFile: %s", err)
+    }
 	err = json.Unmarshal(file, &config)
 	if err != nil {
 		log.Fatalf("Failed to parse configuration parameters: %s", err)

diff --git a/pkg/producers/mongoDB/mongoProducer_test.go b/pkg/producers/mongoDB/mongoProducer_test.go
@@ -9,15 +9,15 @@ import (
 )
 
 func TestProducer_Initialize(t *testing.T) {
-   configFile := "config.json.example"
-
-   producer, err := storage.ProducerFactory("mongo")
-   if err != nil {
-       t.Fatalf("Error reading configuration file: %v", err)
-   }
-   err = producer.Initialize(configFile)
-   if err != nil {
-       t.Fatalf("Error reading configuration file: %v", err)
+	configFile := "config.json.example"
+
+	producer, err := storage.ProducerFactory("mongo")
+	if err != nil {
+		t.Fatalf("Error reading configuration file: %v", err)
+	}
+	err = producer.Initialize(configFile)
+	if err != nil {
+		t.Fatalf("Error reading configuration file: %v", err)
 	}
 }
 

diff --git a/pkg/producers/s3/s3Producer.go b/pkg/producers/s3/s3Producer.go
@@ -25,6 +25,9 @@ type S3Producer struct {
 func (p *S3Producer) Initialize(configFile string) {
 	var config Config
 	file, err := ioutil.ReadFile(configFile)
+	if err != nil {
+        log.Fatalf("Failed to ReadFile: %s", err)
+    }
 	err = json.Unmarshal(file, &config)
 	if err != nil {
 		log.Fatalf("Failed to parse configuration parameters: %s", err)