Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style changes in homepage #1360

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cbum-dev
Copy link
Contributor

What kind of change does this PR introduce?
Ui fixes in main page particularly the "Welcome to the JSON Schema Community" section. Changed the styling and positioning of cards.

Issue Number:

Screenshots/videos:

Screencast.From.2025-01-22.23-07-02.mp4

If relevant, did you update the documentation?
No

Does this PR introduce a breaking change?

@cbum-dev cbum-dev requested a review from a team as a code owner January 22, 2025 17:39
@cbum-dev
Copy link
Contributor Author

Hi everyone, let me know if their is some need of improvement here.

Copy link

github-actions bot commented Jan 22, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 5e1e902

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ee9538b) to head (5e1e902).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1360   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please review and fix the new borders added? They don't work in the dark theme.
Screenshot 2025-01-25 at 10 35 03

@cbum-dev cbum-dev requested a review from benjagm January 25, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Ui fixes in main page.
2 participants