Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve styling in pro-help page #1372

Closed
wants to merge 1 commit into from

Conversation

Thund3rHawk
Copy link

What kind of change does this PR introduce?
Adjust the styling of the pro-help page to address the inconsistent image sizes and resolve the spacing issues between the cards.

Issue Number:

Screenshots/videos:
Screenshot 2025-01-24 at 9 33 44 PM

If relevant, did you update the documentation?
No

Summary
This pr resolves the issue #1368

@Thund3rHawk Thund3rHawk requested a review from a team as a code owner January 24, 2025 16:19
@Thund3rHawk
Copy link
Author

Hey @DhairyaMajmudar please check.

Copy link

github-actions bot commented Jan 24, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 12eb7be

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ee9538b) to head (12eb7be).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1372   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jdesrosiers jdesrosiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing the third requirement

  • The bio should use the markdown component

@Thund3rHawk
Copy link
Author

Hey @jdesrosiers, Just wrap up the bio inside a markdown component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with the Pro-Help page
2 participants