Fix min-max normalization equation

juanmc2005 · Oct 28, 2023 · b27cf1e · b27cf1e
1 parent 637a5e2
commit b27cf1e
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/diart/models.py b/src/diart/models.py
@@ -160,8 +160,9 @@ def __call__(
     ) -> torch.Tensor:
         # Normalize weights
         if weights is not None:
-            weights -= weights.min(dim=1, keepdim=True).values
-            weights /= weights.max(dim=1, keepdim=True).values
+            min_values = weights.min(dim=1, keepdim=True).values
+            max_values = weights.max(dim=1, keepdim=True).values
+            weights = (weights - min_values) / (max_values - min_values)
             weights.nan_to_num_(0.0)
 
         if isinstance(self.model, nn.Module):