-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the check_release.yml
to its own workflow
#2191
base: main
Are you sure you want to change the base?
Conversation
check_release.yml
to its own workflow
@martinRenou I was wondering if this was maybe ready to be merged? Having the built artifacts could help test changes from other PRs more easily, for example #2178. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
nbconvert/.github/workflows/tests.yml Lines 161 to 170 in 6e5fdb3
It would need to be removed from it and added as a separate protection rule |
Head branch was pushed to by a user without write access
Done in 5541bdb. However I don't have access to the repo settings to enable the protection rule in case we want to add one (not sure if this may have an impact on the releaser though). |
check_release
step to a separate workflow, so it's easier to see if it passes