Remove getAttemptedPath functionality

* Functionality does not need to be recorded internally in the service and if desired can be handled by the caller.
justinsa · Mar 14, 2017 · d7f1dcc · d7f1dcc
1 parent d4ba15f
commit d7f1dcc
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 28 deletions.
diff --git a/README.md b/README.md
@@ -156,14 +156,6 @@ $authentication.isInAnyRoles('role1', 'role2', ...);
 $authentication.permit('role1', 'role2', ...);
 ```
 
-This function also stores the current ```$location.path()``` for redirecting to if the user is required to login again.
-
-###getAttemptedPath()
-```JAVASCRIPT
-// Return the last attempted path set by the permit call.
-$authentication.getAttemptedPath();
-```
-
 ###getConfiguration()
 ```JAVASCRIPT
 // Return the configuration object.

diff --git a/ng-authentication-service.js b/ng-authentication-service.js
@@ -213,23 +213,11 @@
          * call this function to determine if a user is permitted and redirect if not.
          */
         permit: function () {
-          if (this.allowed.apply(this, _.toArray(arguments))) {
-            storageService().remove('attemptedPath');
-            return;
+          if (!this.allowed.apply(this, _.toArray(arguments))) {
+            $location.path(
+              this.isAuthenticated() ? configuration.notPermittedRedirectPath : configuration.unauthenticatedRedirectPath
+            );
           }
-          storageService().set('attemptedPath', $location.path());
-          if (this.isAuthenticated()) {
-            $location.path(configuration.notPermittedRedirectPath);
-          } else {
-            $location.path(configuration.unauthenticatedRedirectPath);
-          }
-        },
-
-        /**
-         * Returns the path that the user attempts to access before being redirected.
-         */
-        getAttemptedPath: function () {
-          return storageService().get('attemptedPath');
         },
 
         /**

diff --git a/tests.js b/tests.js
@@ -30,7 +30,6 @@ describe('services', function () {
           'isInAllRoles',
           'isInAnyRoles',
           'permit',
-          'getAttemptedPath',
           'getConfiguration',
           'reauthenticate'
         ];
@@ -472,7 +471,6 @@ describe('services', function () {
             $location.path().should.match('/about');
             $authentication.permit('anonymous');
             $location.path().should.match('/about');
-            ($authentication.getAttemptedPath() === null).should.be.true; // jshint ignore:line
           })
         );
 
@@ -482,7 +480,6 @@ describe('services', function () {
             $location.path().should.match('/about');
             $authentication.permit('all');
             $location.path().should.match('/unauthenticated');
-            $authentication.getAttemptedPath().should.equal('/about');
           })
         );
 
@@ -492,7 +489,6 @@ describe('services', function () {
             $location.path().should.match('/about');
             $authentication.permit('a', 'b');
             $location.path().should.match('/unauthenticated');
-            $authentication.getAttemptedPath().should.equal('/about');
           })
         );
       });