(Optional) Async Script #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohammedNagdy
force-pushed
the
feature/async-jwp-script
branch
from
e08c32a to
5e3f026
Compare
|
Can one of the admins verify this patch? |
|
Hi @smitser could you please check this PR? This will help a lot. |
Hey @MohammedNagdy , I missed this but I am no admin so I can't help you out here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some applications load multiple JW Players in one page. This can cumbersome as it throttles the performance of the client side rendering by clogging the UI thread.
This can be displayed the image below:
Performance stats gathered from a public website using JW Player in React (Performance-Analyzer Chrome Extension)
Solution in the PR
Adding the async attribute optionally as a prop in
<JWPlayer .../>componentLooking forward to hearing suggestions from the team.