-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add clusterName label for identify each kubernetes cluster where K8UP is deployed #1030
Open
lenglet-k
wants to merge
9
commits into
k8up-io:master
Choose a base branch
from
lenglet-k:feat/add-clusterName
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenglet-k
requested review from
Kidswiss and
zugao
and removed request for
a team
December 9, 2024 13:57
Signed-off-by: lenglet-k <lenglet-k@mgdis.fr>
lenglet-k
force-pushed
the
feat/add-clusterName
branch
from
December 9, 2024 13:58
944b4c3
to
f7d2ddf
Compare
lenglet-k
changed the title
change: add clusterName label for identify each kubernetes cluster where K8UP is deployed
feat: add clusterName label for identify each kubernetes cluster where K8UP is deployed
Dec 9, 2024
Kidswiss
requested changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi
Thanks for the contribution!
I found a typo, the rest looks good to me.
Co-authored-by: Kidswiss <kid.gamer@gmail.com>
… feat/add-clusterName
… feat/add-clusterName
… feat/add-clusterName
… feat/add-clusterName
Hi @lenglet-k Looks like the linter doesn't like some new lines in the |
Signed-off-by: lenglet-k <lenglet-k@mgdis.fr>
lenglet-k
force-pushed
the
feat/add-clusterName
branch
from
January 24, 2025 08:59
0cfe2db
to
32ee537
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We use K8up on multiple clusters. These multiple clusters perform backups of namespaces with the same name. All the metrics are sent in the same pushgateway.
As the metrics have the same labels, we cannot have a detailed overview by cluster. This is the way K8UP currently works, which does not allow metric labels to be overloaded. This PR makes it possible to add a clusterName label per Kubernetes cluster.
So in pushgateway we have backup metrics per Kubernetes cluster and per namespace, which improves monitoring of the execution of backups per Kubernetes cluster.
I essentially added a
clusterName
variable equivalent to thepromUrl
variable.See: #1031
Checklist
For Code changes
bug
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelog
area:operator
charts/
directory.