feat(@kadena/react-ui): added textarea and textareafield to the react ui lib #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferreroltd
requested review from
eileenmguo,
sstraatemans,
timoheddes,
alber70g and
webpro
as code owners
🦋 Changeset detectedLatest commit: 95fbe41 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
eileenmguo
reviewed
Oct 10, 2023
packages/libs/react-ui/src/components/TextAreaField/TextAreaField.stories.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: eileenmguo <eileen@kadena.io>
timoheddes
reviewed
Oct 12, 2023
eileenmguo
reviewed
Oct 12, 2023
eileenmguo
reviewed
Oct 13, 2023
eileenmguo
approved these changes
Oct 13, 2023
|
It's still using cloneElement rather than context but since Eileen approved it already, I guess we'll change that later. Looks good otherwise! I'll also approve |
timoheddes
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is including 2 new components, the textArea and the TextAreaField, which wraps the former with the InputWrapper, similar to the TextField